Add posthog local eval support #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds posthog's local eval support. The posthog python sdk essentially downloads all the feature flags for a project periodically and when you ask it if a flag is enabled for a user, it calculates that locally based on the
person_propertiespassed in.This is a backwards-incompatible change, as it replaces the existing
is_enabledmethod in thePosthogAPIClientclass.This also adds the posthog SDK as a dependency of this project. I'm not sure the "right" way to do this sort of thing in poetry/python, where you probably want the codebase upstream to define which version of the posthog client they have in their own project, but you still need some posthog sdk in this project.